D5757: add requestToggleKeepAbove/below

Martin Flöser noreply at phabricator.kde.org
Fri May 12 15:41:24 UTC 2017


graesslin added a comment.


  Your tests in plasma window management do not test the new requests.

INLINE COMMENTS

> test_wayland_windowmanagement.cpp:483
> +    using namespace KWayland::Server;
> +    // this test verifies setting the showing desktop state
> +    QVERIFY(!m_window->isKeepAbove());

copy and paste error

> test_wayland_windowmanagement.cpp:505
> +    using namespace KWayland::Server;
> +    // this test verifies setting the showing desktop state
> +    QVERIFY(!m_window->isKeepBelow());

copy and paste error

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5757

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170512/384a8d08/attachment.html>


More information about the Kde-frameworks-devel mailing list