D5773: [WIP] workarounds for menu positioning

[David Edmundson]

davidedmundson added a comment.


  looks sensible.
  
  Is this only needed for a specific version of Qt? In either case can you check on the Qt 5.7 machine.

INLINE COMMENTS

> qmenu.cpp:112
> +    
> +    QQuickItem *item = qobject_cast<QQuickItem *>(m_visualParent.data());
> +    if (item) {

there's a code path in open that says:

  if (m_visualParent) {
       parentItem = qobject_cast<QQuickItem *>(m_visualParent.data());
   } else {
       parentItem = qobject_cast<QQuickItem *>(parent());
   }

does this not need doing for the latter branch?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5773

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170508/7e55eb81/attachment.html>