D5745: recreate plasmashellsurf on exposed, destoy on hidden

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> dialog.cpp:1123
>      if (event->type() == QEvent::Expose) {
> -        // FIXME TODO: We can remove this once we depend on Qt 5.6.1+.
> -        // See: https://bugreports.qt.io/browse/QTBUG-26978
> -        KWindowSystem::setState(winId(), NET::SkipTaskbar | NET::SkipPager);
> +        if (!d->shellSurface) {
> +            KWindowSystem::setState(winId(), NET::SkipTaskbar | NET::SkipPager);

we also get an expose on hide, but with a null region.

Can you add:

  auto ee = static_cast<QExposeEvent*>(event);

+        if (ee->region().isNull()) {
+            return false;
+        }

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5745

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170507/8e8c37bc/attachment-0001.html>