D5638: Use a single QNAM (and a disk cache) for HTTP jobs

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> httpworker.cpp:41
> +        QStorageInfo storageInfo(cacheLocation);
> +        cache.setMaximumCacheSize(qMin(50, (int)(storageInfo.bytesTotal() / 1000)));
> +        nam.setCache(&cache);

50 bytes? isn't that a bit small? :)

> httpworker.cpp:57
> +
> +Q_GLOBAL_STATIC(HTTPWorkerNAM, NetworkManager)
>  

the uppercase first letter is weird, for a variable.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D5638

To: leinir, whiting, apol, dfaure
Cc: dfaure, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170507/84d15cbf/attachment.html>