D5638: Use a single QNAM (and a disk cache) for HTTP jobs

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu May 4 22:30:01 UTC 2017


apol added inline comments.

INLINE COMMENTS

> httpworker.cpp:36
> +    HTTPWorkerNAM()
> +        : nam(new QNetworkAccessManager)
> +        , mutex(new QMutex)

These all are leaking.

> httpworker.cpp:48
> +    QNetworkAccessManager* nam;
> +    QMutex* mutex;
> +

Drop *, leaking mutexes

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D5638

To: leinir, whiting, apol
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170504/f5eeeda8/attachment.html>


More information about the Kde-frameworks-devel mailing list