D5104: Error page, correctly load the image (with a real URL)
Michael Pyne
noreply at phabricator.kde.org
Thu Mar 30 01:46:32 UTC 2017
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D5104#97246, @ltoscano wrote:
> Thanks for checking: with this patch you should not see the error that I reported in the summary/commit message. Is it the case? If it is, I guess that the patch can go in.
> It's interesting to note that I have the same issue that you reported on one of my two machines; it works on the other. Same operating system, same configuration, same kdesrc-build O.o.
I didn't get the exact SimpleJob error message you noted, no. But I didn't remember to check before applying the patch either. Either way it makes it no worse, so +1.
REPOSITORY
R313 KHtml
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5104
To: ltoscano, mpyne
Cc: mpyne, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170330/000c2de9/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list