D5243: if the user did set an implicit size, keep it

Marco Martin noreply at phabricator.kde.org
Wed Mar 29 15:03:09 UTC 2017


mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  if the user code did something like
  IconItem {
  
    implicitWidth: 32
    implicitHeight: 32
  
  }
  
  then never automatically update implicitWidth or height.
  this favors compatibility and fixes the desktop
  toolbox appearance

TEST PLAN
  textbox works, other icon items in plasmashell seems properly sized.
  applet alternatives fix is still needed

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/implicitSize

REVISION DETAIL
  https://phabricator.kde.org/D5243

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170329/8421c9e2/attachment.html>


More information about the Kde-frameworks-devel mailing list