D5215: [ModelContextMenu] Use Instantiator insteadof Repeater-and-reparent-hack
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Mar 28 12:14:51 UTC 2017
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
TEST PLAN
Clicking the "add widgets" button multiple times in widget explorer no longer crashes/confuses it because the Repeater destroys its items when model is assigned a new JS Array as is done in widget explorer.
Also the category selection in widget explorer still works.
There's no addMenuItemAt method and the old code also didn't care about the order of items so it shouldn't be worse than before.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5215
AFFECTED FILES
src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml
To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170328/cdc37c9d/attachment.html>
More information about the Kde-frameworks-devel
mailing list