D5181: API dox: fix missing note to call setXMLFile with KParts::MainWindow

David Faure noreply at phabricator.kde.org
Sun Mar 26 14:53:59 UTC 2017


dfaure added a comment.


  Seems right. The alternative is to make it work.
  Not sure which solution is better.
  
  - kxmlgui/src/kxmlguiwindow.cpp
  
  +++ kxmlgui/src/kxmlguiwindow.cpp
  @@ -203,6 +203,8 @@ void KXmlGuiWindow::setupGUI(const QSize &defaultSize, StandardWindowOptions opt
  
    if (options & Create) {
        createGUI(xmlfile);
  
  +    } else if (!xmlfile.isEmpty()) {
  +        setXMLFile(xmlfile);
  
    }
     
    if (d->defaultSize.isValid()) {

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D5181

To: kossebau, elvisangelaccio, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170326/af66c264/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list