D4847: KAuth integration in document saving

[David Faure]

dfaure added a comment.


  Looks good to me. Just some minor things I noticed.

INLINE COMMENTS

> katesecuretextbuffer.cpp:26
> +#include <errno.h>
> +#include <stdio.h>
> +#endif

where is stdio.h used?

> katesecuretextbuffer.cpp:100
> +        }
> +        const qint64 len = 4096;
> +        char buffer[len];

make this static so that the next line doesn't look to the compiler like a variable-size array (which isn't standard, although I'm not sure about C++11).

Maybe it has to be a #define even, I'm not sure.

> katesecuretextbuffer_p.h:21
> +
> +#ifndef KATE_SECURE_TEXTBUFFER_H
> +#define KATE_SECURE_TEXTBUFFER_H

...._P_H to match the header filename

> katesecuretextbuffer_p.h:83
> +     */
> +    static ActionReply savefile(const QVariantMap &args);
> +

A static slot is.... creative ;-)
But if it works, that's fine.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4847

To: martinkostolny, dhaumann, #ktexteditor
Cc: apol, dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170325/20768bd7/attachment-0001.html>