D5143: Introduce fetch-translations build command

[Aleix Pol Gonzalez]

apol marked 2 inline comments as done.
apol added a comment.


  will send another review with the documentation

INLINE COMMENTS

> sitter wrote in KDECMakeSettings.cmake:302
> I wonder if we shouldn't use `ExternalProject` here. The advantage being that cmake would manage the clone and make sure it is updated as necessary. Disadvantageously, it doesn't seem to do `depth=1` presently 🐛, so I am not sure this would be a net-win.
> 
>   include(ExternalProject)
>   ExternalProject_Add(releaseme
>       PREFIX "${CMAKE_BINARY_DIR}/releaseme"
>       GIT_REPOSITORY https://anongit.kde.org/releaseme.git
>       CONFIGURE_COMMAND ""
>       BUILD_COMMAND ""
>       INSTALL_COMMAND ""
>   )
> 
> (NOTE: dependable target would then be `releaseme`, also paths change with this)

A first approach used it, I decided to remove it because it didn't add much...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, aacid, ltoscano
Cc: sitter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170323/955f0ced/attachment.html>