D5104: Error page, correctly load the image (with a real URL)

Luigi Toscano noreply at phabricator.kde.org
Sat Mar 18 22:37:08 UTC 2017


ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The local address to the image is injected into an HTML page (the
  error page). This address needs to be a proper URL with file:///,
  not just the absolute path to the image file - otherwise
  KIO::SimpleJobPrivate::simpleJobInit complains with "Invalid URL".

TEST PLAN
  Compiles, and when trying to load an invalid address in Konqueror
  with the KHTML part, the warning picture on the top-left corner is
  now visible.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5104

AFFECTED FILES
  src/khtml_part.cpp

To: ltoscano
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170318/b21d38c1/attachment.html>


More information about the Kde-frameworks-devel mailing list