D5090: More focus on KIO than Konqueror

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> smbrodlg.cpp:176-186
> +   return i18n("<p><h1>Windows Shares</h1>Applications using the "
> +        "SMB kioslave (like Konqueror) are able to access shared Microsoft "
> +        "Windows file systems, if properly configured. If there is a "
>          "specific computer from which you want to browse, fill in "
>          "the <em>Browse server</em> field. This is mandatory if you "
>          "are not running Samba locally. The <em>Broadcast address</em> "
>          "and <em>WINS address</em> fields will also be available, if you "

There are no fields named Browse server, Broadcast address, WINS address in the dialog, see
https://bugs.kde.org/show_bug.cgi?id=253389

Last occurences of these strings are in
https://websvn.kde.org/tags/KDE/3.3.0/kdebase/kcontrol/kio/ksmboptdlg.cpp?view=markup

ksmboptdialog.cpp was replaced with smbrodlg.cpp without these strings with
https://websvn.kde.org/trunk/kdebase/kcontrol/kio/smbrodlg.cpp?revision=76131&view=markup&pathrev=76131

Therefore everything about Browse server, Broadcast address, WINS address  should be removed.

Otherwise looks good to me.

Thanks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5090

To: ltoscano, dfaure
Cc: lueck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170318/dd4ad815/attachment.html>