Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

[Igor Poboiko]

> On Март 15, 2017, 8:55 д.п., Matthieu Gallien wrote:
> > Ship It!
> 
> Matthieu Gallien wrote:
>     KFileMetaData being in use by itself, IMHO Baloo problematics should not block this correction.
> 
> Matthieu Gallien wrote:
>     I almost forgot to ask an automatic test for your fix. Please do not ship without it.
> 
> Matthieu Gallien wrote:
>     You can see that current tests do not cover the line you are modifying: https://build.kde.org/view/Frameworks%20kf5-qt5/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/cobertura/src_extractors/plaintextextractor_cpp/ .

Unfortunately, I've got not that much experience in writing autotests...

I think the proper test that would have revealed that problem would be actually a test for ExtractorCollection::fetchExtractors (just check some more or less obvious mimetypes and see that correct plugins are returned).
If you think this is fine, I can see how other tests are done and then add one.


- Igor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130013/#review102851
-----------------------------------------------------------


On Март 14, 2017, 9:16 п.п., Igor Poboiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130013/
> -----------------------------------------------------------
> 
> (Updated Март 14, 2017, 9:16 п.п.)
> 
> 
> Review request for KDE Frameworks and Anthony Fieroni.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer matches ANY of the text/ mimetypes.
> This broke completely Baloo indexing e.g. simple plain text files.
> Introduced check however allows to provide "text/plain" as supported mimetype for the extractor and hope that everything containing plain text will be inherited from it.
> 
> 
> Diffs
> -----
> 
>   src/extractors/plaintextextractor.cpp 26e1247 
> 
> Diff: https://git.reviewboard.kde.org/r/130013/diff/
> 
> 
> Testing
> -------
> 
> KFileMetaData compiles.
> Baloo indexes plain text files.
> Everybody is happy.
> 
> 
> Thanks,
> 
> Igor Poboiko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170316/219997a9/attachment.html>