Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
Anthony Fieroni
bvbfan at abv.bg
Wed Mar 15 04:13:45 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130013/#review102846
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Fieroni
On Март 14, 2017, 11:16 след обяд, Igor Poboiko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130013/
> -----------------------------------------------------------
>
> (Updated Март 14, 2017, 11:16 след обяд)
>
>
> Review request for KDE Frameworks and Anthony Fieroni.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer matches ANY of the text/ mimetypes.
> This broke completely Baloo indexing e.g. simple plain text files.
> Introduced check however allows to provide "text/plain" as supported mimetype for the extractor and hope that everything containing plain text will be inherited from it.
>
>
> Diffs
> -----
>
> src/extractors/plaintextextractor.cpp 26e1247
>
> Diff: https://git.reviewboard.kde.org/r/130013/diff/
>
>
> Testing
> -------
>
> KFileMetaData compiles.
> Baloo indexes plain text files.
> Everybody is happy.
>
>
> Thanks,
>
> Igor Poboiko
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170315/b29245f6/attachment.html>
More information about the Kde-frameworks-devel
mailing list