D5032: drop examples dir
Harald Sitter
noreply at phabricator.kde.org
Mon Mar 13 10:36:24 UTC 2017
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- it does not build on its own (doesn't find_package anything)
- it is not wired into the overall build (so you can't build it as part of that either)
- it does not get installed (making it nigh impossible to find for 3rd party devs)
- 2/2 kde devs did not even know this example exists
- it contains a Messages.sh which is run and extracts and even gets translations (! what waste !)
to fix all of the above drop the entire directory. if someone wants to
bring it back, the above issue list should be dealt with. in particular
the Messages.sh problem (conceivably the extract line could be commented
out with a todo note that it needs enabling for i18n).
REPOSITORY
R308 KRunner
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5032
AFFECTED FILES
examples/runner/CMakeLists.txt
examples/runner/Messages.sh
examples/runner/homefilesrunner.cpp
examples/runner/homefilesrunner.h
examples/runner/plasma-runner-example-homefiles.desktop
To: sitter, broulik
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170313/004439e6/attachment.html>
More information about the Kde-frameworks-devel
mailing list