D4947: [KTextEditor] Expose additional internal View's functionality to the public API

[John Salatas]

jsalatas added a comment.


  In https://phabricator.kde.org/D4947#94562, @dhaumann wrote:
  
  > Reading this API, I still have some general thoughts:
  >  This is the first time we expose the concept of "visible lines". So far, this only exists internally in katetextfolding.h/cpp. By itself, this is fine, but given we do not expose folding information so far, I think the API is not complete.
  >  If we already provide infos about visible first / last visible line in a view, the complete API should also contain functions like isLineVisible(int line). But here, we have a problem, since the fistVisibleLine() and lastVisibleLine() are not the text folding lines, instead, its the visually visible drawn line on screen. Here, the term "visible" is used in two different contexts: once for screen visibility, and once for folding information. Internally, KTextEditor uses terms viewLine or displayedLine for this. Maybe displayedLine is the best here?
  >
  > Any comments? Are we lacking more API to make it feel complete?
  
  
  Actually I was looking at it yesterday. It seems to be a draft of a FoldingInterface (https://cgit.kde.org/ktexteditor.git/tree/src/draft/foldinginterface.h) which I guess, when completed, will provide a rather extensive (complete ?) folding API.
  
  @cullmann, I'm not sure if you are still working with it's implementation. If this is not the case, I guess I could implement it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4947

To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor
Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170312/4f81c627/attachment-0001.html>