D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

[Yuen Hoe Lim]

yuenlim created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  When posting large raw image data to imgur in QuickShare, the KIO job ends up triggering a notification that displays the entire raw image data, causing plasma to freeze:
  
  "Transferring: Finished" "data:image/png;base64, <the entire raw data of the image to paste>"
  
  see https://phabricator.kde.org/D4945 for details.
  
  This patch truncates the url string assigned to the job description at 100 characters and so limits the length of the string that gets sent to the notification.
  
  Only emitTransferring() is related to the issue I'm trying to fix, but it looked like it was probably sensible to apply the same treatment in the other cases of assigning url string to description as well, so I did.
  
  Very unfamiliar with the code here! Would appreciate comments for improving the patch. Also not sure who are the right reviewers for this so please add if I missed it out.

TEST PLAN
  With a 3000x2000 display and using a blank desktop with the "Evening Glow by Ian Hex" wallpaper.
  
  1. Take a screenshot of the whole blank desktop with Spectacle
  2. Click "Copy to Clipboard"
  3. Right click QuickShare plasmoid > Paste
  4. Select Imgur action
  
  Before: plasma becomes unresponsive, shell output should indicate the notification as in description.
  
  After: Plasma does not become unresponsive, notification shows with truncated string.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5013

AFFECTED FILES
  src/core/job.cpp
  src/core/job_p.h

To: yuenlim, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170311/aee04fd5/attachment.html>