Review Request 129985: [kio-extras] Thumbs for audio files

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/#review102779
-----------------------------------------------------------


Fix it, then Ship it!




Looks good to me now.


thumbnail/audiothumbnail.desktop (line 5)
<https://git.reviewboard.kde.org/r/129985/#comment68421>

    You can drop this translation, it will be overridden by scripty anyway.


- Elvis Angelaccio


On March 6, 2017, 5:44 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129985/
> -----------------------------------------------------------
> 
> (Updated March 6, 2017, 5:44 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   cmake/FindTaglib.cmake PRE-CREATION 
>   thumbnail/CMakeLists.txt 7a1ee45a 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170310/317980f3/attachment.html>