D4968: Mac OS (X) has a POSIX-compliant /bin/sh too

[René J.V. Bertin]

rjvbb added a comment.


  
  
  In https://phabricator.kde.org/D4968#93542, @bcooksley wrote:
  
  > Something is definitely odd about this revision - it doesn't appear to have been submitted using Arcanist.
  >  The branch, along with local commit information is missing, and Arcanist always uploads context.
  
  
  No, it doesn't always and yes, it has been committed via an up-to-date Arcanist, using `arc diff --raw`.
  
  > How does this KDevelop integration work?
  
  Like ReviewBoard integration, which is currently the only thing feasible: it's coupled to the "patch review" feature which works on local changes that aren't yet committed, i.e. a patch made via `git diff`, `svn diff` etc.
  ReviewBoard was clever enough to deal with such patches that contain enough information to reconstruct context which is evidently available once you know what repository the patch applies to.
  
  If Phabricator isn't capable of doing this that's a regression that IMHO they (or the Arcanist devs) ought to deal with.
  
  The Phabricator export plugin is new, written by me with feedback from Aleix. We're aware that it'd be good to design a way to provide a more feature full integration when using simple patchfiles isn't acceptable but that's going to take time.
  
  If it does use Arcanist, please make sure your Arcanist is up to date (do not install via Macports or any other mechanism other than that laid out by Phabricator upstream - it's unsupported and may give you older versions which do not include the most recent fixes).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4968

To: rjvbb, #frameworks, dfaure
Cc: bcooksley, dfaure, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170308/a7b3c013/attachment-0001.html>