Review Request 129987: Sanitize shortcut list on read/write from kdeglobals

Albert Astals Cid aacid at kde.org
Mon Mar 6 21:58:33 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129987/
-----------------------------------------------------------

(Updated March 6, 2017, 9:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 59b184735c057482995cc0a8014bb90d12f09cf9 by Albert Astals Cid to branch master.


Bugs: 375555
    https://bugs.kde.org/show_bug.cgi?id=375555


Repository: kconfig


Description
-------

For some reason some people have kdeglobals entries like
   Close=Ctrl+W; Ctrl+Esc; Ctrl+W; Ctrl+Esc;
having the same shortcut more than once in the shortcut declaration is clearly bogus so fix it


Diffs
-----

  src/gui/kstandardshortcut.cpp 9e7b1cf 

Diff: https://git.reviewboard.kde.org/r/129987/diff/


Testing
-------

Created broken kdeglobals file manually, don't get warnings anymore


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170306/99793360/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list