D4947: [KTextEditor] Expose additional internal View's functionality to the public API

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> mwolff wrote in view.h:464
> should be scrollToPos, c -> cursor, and make the cursor const

I would even favour setScrollPosition(). Avoid abbreviations whenever possible. And we already have many other API that contains the full word position.

And should it not be const KTextEditor : : Cursor &?

> mwolff wrote in view.h:495
> lastVisibleLine

Just to make sure this api is well understood: if code is folded, many hundred lines can be between firstVisibleLine and lastVisibleLine. Please add a comment to the api documentation to reflect this...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4947

To: jsalatas, #ktexteditor, #frameworks, mwolff
Cc: dhaumann, anthonyfieroni, mwolff, kwrite-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170306/62dac1ce/attachment.html>