Review Request 129986: KUrlRequester does not allow proper save filedialog

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129986/#review102727
-----------------------------------------------------------




src/widgets/kurlrequester.h (line 133)
<https://git.reviewboard.kde.org/r/129986/#comment68382>

    @since 5.33



src/widgets/kurlrequester.h (line 139)
<https://git.reviewboard.kde.org/r/129986/#comment68383>

    @since 5.33



src/widgets/kurlrequester.cpp (line 199)
<https://git.reviewboard.kde.org/r/129986/#comment68384>

    I wonder why this method doesn't use the member variables rather than taking them all as arguments...
    
    Make the method static, while you're here? It will make more sense then.


- David Faure


On March 5, 2017, 7:46 p.m., Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129986/
> -----------------------------------------------------------
> 
> (Updated March 5, 2017, 7:46 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 371685
>     https://bugs.kde.org/show_bug.cgi?id=371685
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Using a KUrlRequester to select a file to save is not currently working. The file dialog is always opening in "open" mode, never in "save" mode. My patch adds a method to call setAcceptMode on the file dialog. Some users reported that the current behavior completely breaks the functionnality on some platforms(Gnome), making it impossible to select a non existing file.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kurlrequester.h 51c1259 
>   src/widgets/kurlrequester.cpp 62e1fea 
> 
> Diff: https://git.reviewboard.kde.org/r/129986/diff/
> 
> 
> Testing
> -------
> 
> Tested locally, the dialog opening from the KUrlRequester is now a proper "save" dialog
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/a87a0182/attachment.html>