Review Request 129985: [kio-extras] Thumbs for audio files

[Elvis Angelaccio]

> On March 5, 2017, 5:58 p.m., David Faure wrote:
> > Heh KDE3 is back (we had such functionality long ago).
> > 
> > No objection about the feature itself, but can it be off by default? I hate computers that make noise^H^Hsounds unexpectedly. Can be very embarrassing when it happens next to someone who's sleeping for instance (at home, in a plane, etc.), or during a phone conference, etc.

I think there is a misunderstanding here? This is not about preview of audio tracks, but preview of album covers (pictures) embdedded in the audio files :p


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/#review102722
-----------------------------------------------------------


On March 5, 2017, 5:51 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129985/
> -----------------------------------------------------------
> 
> (Updated March 5, 2017, 5:51 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   cmake/FindTaglib.cmake PRE-CREATION 
>   thumbnail/CMakeLists.txt 7a1ee45a 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/10be031e/attachment.html>