Review Request 129985: [kio-extras] Thumbs for audio files

Elvis Angelaccio elvis.angelaccio at kde.org
Sun Mar 5 17:21:42 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/#review102721
-----------------------------------------------------------




thumbnail/audiocreator.cpp (line 213)
<https://git.reviewboard.kde.org/r/129985/#comment68381>

    `DrawFrame` has been recently deprecated, see https://cgit.kde.org/kio-extras.git/commit/?id=db7f8d0c945880b0fbb5ea9ad8ed6817d6ba0340


- Elvis Angelaccio


On March 5, 2017, 3:02 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129985/
> -----------------------------------------------------------
> 
> (Updated March 5, 2017, 3:02 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   cmake/FindTaglib.cmake PRE-CREATION 
>   thumbnail/CMakeLists.txt 7a1ee45a 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/c637920e/attachment.html>


More information about the Kde-frameworks-devel mailing list