Review Request 129985: [kio-extras] Thumbs for audio files

[Elvis Angelaccio]

> On March 5, 2017, 2 p.m., Elvis Angelaccio wrote:
> > thumbnail/CMakeLists.txt, lines 241-243
> > <https://git.reviewboard.kde.org/r/129985/diff/2/?file=492266#file492266line241>
> >
> >     This does not work, if you need to do:
> >     
> >     ```
> >     if (TAGLIB_FOUND)
> >        install(FILES audiothumbnail.desktop DESTINATION ${SERVICES_INSTALL_DIR})
> >     endif()
> >     ```
> 
> Anthony Fieroni wrote:
>     Yeah, i want to do this. Why it will not work?

The if() needs to be outside the `install()` call, otherwise I get:

> CMake Error at cmake_install.cmake:324 (file):
  file INSTALL cannot find "/home/elvis/dev/kde/src/kio-extras/thumbnail/if".


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/#review102717
-----------------------------------------------------------


On March 5, 2017, 11:27 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129985/
> -----------------------------------------------------------
> 
> (Updated March 5, 2017, 11:27 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   cmake/FindTaglib.cmake PRE-CREATION 
>   thumbnail/CMakeLists.txt da6e4233 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/0df1a6ba/attachment-0001.html>