D4937: Add KFileWidget::setSelectedUrl()

David Faure noreply at phabricator.kde.org
Sun Mar 5 13:50:17 UTC 2017


dfaure added inline comments.

INLINE COMMENTS

> fvogt wrote in kfilewidget.h:150
> No, I meant setSelectedUrl indeed. It works for relative URLs as well.
> Both the function itself and setLocationText check url.isRelative()

Ah right, OK.

But people are not going to URL-escape filenames and then we'll have the same bug again ;-)

They'll write QUrl(fileName) which won't work for this purpose, for instance for files called "a:b" and "a#b" it will lead to QUrl("a:b") or QUrl("a#b") which will be parsed as "scheme==a" and "fragment==b" respectively,

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4937

To: dfaure, fvogt
Cc: fvogt, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/8952f788/attachment.html>


More information about the Kde-frameworks-devel mailing list