D4937: Add KFileWidget::setSelectedUrl()

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> fvogt wrote in kfilewidget.h:150
> This function only works correctly for URLs, as filenames can contain ':'s.
> However, for those setSelectedUrl is the right function, so I'd mark this
> function as deprecated

Very good point.

But there might be other users of this class who need the ability to select by filename.
I think this means we have two options:

- changing setSelection to only handle filenames, including those with a ':' (bad, not backwards compatible)
- adding a setSelectedFileName(const QString &fileName), and then we can deprecated setSelection(QString).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4937

To: dfaure, fvogt
Cc: fvogt, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/de674cb1/attachment.html>