Review Request 129985: [kio-extras] Thumbs for audio files

[David Faure]

> On March 5, 2017, 10:21 a.m., Elvis Angelaccio wrote:
> > thumbnail/audiothumbs.desktop, line 7
> > <https://git.reviewboard.kde.org/r/129985/diff/1/?file=492263#file492263line7>
> >
> >     Not sure if wildcards are allowed by the .desktop specification. @David are they?
> 
> Anthony Fieroni wrote:
>     It should be allowed.

The desktop file specification does not support wildcards, but that doesn't matter, since it's the spec for Type=Application desktop files.
This is a Type=Service desktop file, it's KDE specific, so given that (IIRC) PreviewJob supports wildcards, it's all fine.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/#review102711
-----------------------------------------------------------


On March 5, 2017, 11:27 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129985/
> -----------------------------------------------------------
> 
> (Updated March 5, 2017, 11:27 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   cmake/FindTaglib.cmake PRE-CREATION 
>   thumbnail/CMakeLists.txt da6e4233 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/286f849c/attachment.html>