Review Request 129985: [kio-extras] Thumbs for audio files

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129985/#review102711
-----------------------------------------------------------



+1
I've been using it for a while and works fine (from [here](https://github.com/bvbfan/Audio-thumbs)). There is also another unofficial plugin on github that people are using, I think there is a need for an audio thumbnailer and it would be nice to have it upstream.


thumbnail/CMakeLists.txt (line 217)
<https://git.reviewboard.kde.org/r/129985/#comment68367>

    This is not supposed to be used outside of FindXXX.cmake files. You should probably add a proper FindTaglib.cmake, look at kfilemetadata as example.



thumbnail/audiothumbs.desktop (line 7)
<https://git.reviewboard.kde.org/r/129985/#comment68371>

    Not sure if wildcards are allowed by the .desktop specification. @David are they?



thumbnail/audiothumbs.desktop (line 9)
<https://git.reviewboard.kde.org/r/129985/#comment68370>

    The other plugins use `foothumbnail` as name, so here `audiothumbnail` would be more consistent.



thumbnail/audiothumbs.h (line 26)
<https://git.reviewboard.kde.org/r/129985/#comment68368>

    Prefer `#include <KIO/ThumbCreator>`



thumbnail/audiothumbs.h (line 34)
<https://git.reviewboard.kde.org/r/129985/#comment68369>

    Prefer `override`, same below.


- Elvis Angelaccio


On March 5, 2017, 4:51 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129985/
> -----------------------------------------------------------
> 
> (Updated March 5, 2017, 4:51 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   thumbnail/CMakeLists.txt da6e4233 
>   thumbnail/audiothumbs.cpp PRE-CREATION 
>   thumbnail/audiothumbs.desktop PRE-CREATION 
>   thumbnail/audiothumbs.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170305/c4df3af4/attachment.html>