D4911: add Baloo DBus signals for moved or removed files
Vishesh Handa
noreply at phabricator.kde.org
Fri Mar 3 23:37:48 UTC 2017
vhanda added a comment.
I'm not the maintainer of Baloo any more, so I don't want to give it a clear Yes / No.
This patch is going to be a big CPU hog. For files this will barely have an impact, but for folders of a large enough size, it's going to result in tons of dbus signals, and more importantly, tons of database lookups and full path constructions. It really will add up. In an earlier version of Baloo, we used to store the full file paths, which meant when a folder moved, every sub-file/folder's URL had to be updated. That was a huge CPU burner. This patch isn't that bad, but it's half way there.
I cannot see what advantage these signals add, apart from possibly making Baloo more introspect-able. If it's to build applications on top of Baloo, I would recommend against it. The kernel provides file system monitoring APIs which should be used instead.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D4911
To: mgallien, vhanda
Cc: apol, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170303/cb663c97/attachment.html>
More information about the Kde-frameworks-devel
mailing list