Review Request 127409: Make sure we're not forcing the window to be created prematurely

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127409/
-----------------------------------------------------------

(Updated mar. 3, 2017, 4:52 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

Only update the properties that require a winId when visible, otherwise let updateVisibility() take care about them.


Diffs
-----

  src/plasmaquick/dialog.cpp 7bb63c5 

Diff: https://git.reviewboard.kde.org/r/127409/diff/


Testing
-------

I don't get platform creations being forced on gdb.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170303/c2e3d13f/attachment.html>