D4911: add Baloo DBus signals for moved or removed files

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Mar 3 12:46:04 UTC 2017


apol added a comment.


  autotests would be very welcome!

INLINE COMMENTS

> transaction.cpp:134
> +
> +    const QVector<quint64> children = docUrlDB.getChildren(parentId);
> +

Return right away?

> apol wrote in metadatamover.cpp:49
> const auto &

Uh you are right, no need for a const&, I assumed it were QString for some reason.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D4911

To: mgallien
Cc: apol, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170303/4d71991a/attachment.html>


More information about the Kde-frameworks-devel mailing list