[Differential] [Changed Subscribers] D4847: KAuth integration in document saving

[Martin Gräßlin]

graesslin added subscribers: davidedmundson, graesslin.
graesslin added a comment.


  I really like what I see here!
  
  Just a thought: what happens if the file is not owned by root, but e.g. by www-data? If I understand the code correctly it might change to be owned by root due to the usage of QSaveFile?
  
  I would like to see some KAuth experts (e.g. @davidedmundson ) to have a good look at the code to verify that it doesn't introduce vulnerabilities. As far as I studied the code I didn't see anything bad.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4847

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: martinkostolny, #ktexteditor
Cc: graesslin, davidedmundson, palant, kwrite-devel, #frameworks, head7, cullmann, kfunk, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170301/9dc06313/attachment.html>