D6376: Fix double delete crash during shutdown

[Christoph Cullmann]

cullmann added a comment.


  Hi,
  
  if you can arrive twice for the same mediaobject in finishNotification e.g. via close and onAudioFinished you might insert it twice and delete it twice.
  If not, this change helps nothing.
  
  Unfortunately I have no way to reproduce.
  
  We can just discard that and I can still reopen it, if I have a way to reproduce.
  
  Reading the MediaObject docs  NotifyByAudio::close should avoid that onAudioFinished is triggered by stop() not emiting, therefore I am not sure how that should happen.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D6376

To: cullmann, #frameworks
Cc: aacid, mpyne, rjvbb
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170626/cbafd633/attachment.html>