D6277: Emit errors when keditbookmarks is missing

David Faure noreply at phabricator.kde.org
Fri Jun 23 19:59:47 UTC 2017


dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Good fix, thanks.

INLINE COMMENTS

> aacid wrote in kbookmarkmanager.cpp:341
> i'd go for non const as the other two methods, yes they could be const since they're not modyfing the object, i guess what the original author had in mind is a meaning of "this changes things eventually" so that's why it isn't const, or maybe it was just a mistake :D

The author is me, and the calling methods are slots (which are typically not const) ;)

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks, dfaure
Cc: dfaure, aacid, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170623/0ca9a5db/attachment.html>


More information about the Kde-frameworks-devel mailing list