D6340: Fix incorrect error detection for missing knsrc files

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Jun 22 13:06:27 UTC 2017


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  +1 for proper error messages!

INLINE COMMENTS

> engine.cpp:130
> +        emit signalError(i18n("Configuration file exists, but cannot be opened: \"%1\"", configfile));
> +        qCritical() << "The knsrc file '" << configfile << "' was found but could not be opened." << endl;
> +        return false;

are you sure the `endl` is necessary?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6340

To: leinir, #knewstuff, apol
Cc: apol, #frameworks, ZrenBot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170622/6d3e1b3f/attachment.html>


More information about the Kde-frameworks-devel mailing list