D6313: WIP: Support device pixel ratio in icon loader and engine

Christoph Feck noreply at phabricator.kde.org
Wed Jun 21 13:58:16 UTC 2017


cfeck added inline comments.

INLINE COMMENTS

> cfeck wrote in kiconloader.cpp:863
> Please use some rounding here. Scaling factors such as 1.4 cannot be represented exactly.
> 
> Either add some formatting specifiers, e.g. for three decimal places, or use qRound(scale * 1000).

Just checked that the default precision is 6 digits, so maybe not that important.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: cfeck, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170621/8bb81f68/attachment.html>


More information about the Kde-frameworks-devel mailing list