D6277: Emit errors when keditbookmarks is missing

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> valeriymalov wrote in kbookmarkmanager.cpp:341
> Uh oh, I'd assume startKEditBookmarks should be const (which I forgot) since it doesn't change the object, yet we need to emit non-const singal error. So should it be const or not?
> 
> Also, I'm looking at slotEditBookmarks and slotEditBookmarksAtAddress, and don't understand why those weren't const, since they don't have side-effects too, although I might be missing something since I'm not too familiar with Qt.

i'd go for non const as the other two methods, yes they could be const since they're not modyfing the object, i guess what the original author had in mind is a meaning of "this changes things eventually" so that's why it isn't const, or maybe it was just a mistake :D

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170620/533661f7/attachment.html>