D6279: API dox: add notes to KActionCollection about QAction ownership handling

David Faure noreply at phabricator.kde.org
Tue Jun 20 07:22:04 UTC 2017


dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kactioncollection.h:325
>       *
> +     * The ownership of the action object is not transferred. If the action is destroyed
> +     * it will be removed automatically from the KActionCollection.

I would add a newline after the '.'
Otherwise it looks like the second sentence is related to the first, but it's not really.

> kactioncollection.h:341
>       *
> +     * The ownership of the action objects is not transferred. If the action is destroyed
> +     * it will be removed automatically from the KActionCollection.

same

REPOSITORY
  R263 KXmlGui

BRANCH
  apidoxQActionOwnership

REVISION DETAIL
  https://phabricator.kde.org/D6279

To: kossebau, #frameworks, dfaure
Cc: apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170620/0b205dd4/attachment.html>


More information about the Kde-frameworks-devel mailing list