D6197: Add basic KAuth support to file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> aacid wrote in file.cpp:1382
> Why is there an ifdef anyway? KAuth has at least a mac backend (no idea how much it works) but adding an ifdef at this level seems the wrong thing to do.

This method will be used by FileProtocol::mkdir and FileProtocol::chmod which are not virtual method. So when called in windows  this must return false for the time being. So IMO ifdef or something similar is necessary. What do you suggest?

> eliasp wrote in file.h:107
> I find `execWithRoot()` to be a bit misleading, as the goal shouldn't be to always elevate to `root`'s privileges but to only what's required to execute the specific operation (e.g. browse `/home/someotheruser` doesn't need `root`'s privileges but only `someotheruser`'s privileges).
> 
> Always elevating to root is IMHO by far too permissive.

I agree with you on the part that execWithRoot() is slightly misleading. So I changed it to execWithElevatedPrivilege(). And acquiring somotheruser's privileges still requires elevated privilege does it not?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6197

To: chinmoyr, elvisangelaccio, #frameworks, dfaure
Cc: eliasp, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170620/7fc6942a/attachment.html>