D6277: Emit errors when keditbookmarks is missing

[Valeriy Malov]

valeriymalov marked 2 inline comments as done.
valeriymalov added inline comments.

INLINE COMMENTS

> aacid wrote in kbookmarkmanager.cpp:335
> Have you checked errorString actually returns something?
> 
> Given startDetached is static it seems kind of weird it would update the "this" errorString

Yeah it returns unknown error, my mistake, I suppose I should just switch back to call without object since it's a static method
There don't seem to be any informative errors apart from FailedToStart (which is the only one we are interested in?) in QProcess anyway

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170619/6069e43a/attachment.html>