D6277: Emit errors when keditbookmarks is missing

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kbookmarkmanager.cpp:330
> +{
> +    QProcess *keditbookmarks = new QProcess(this);
> +    bool success = keditbookmarks->startDetached(QStringLiteral("keditbookmarks"), args);

You're leaking keditbookmarks

> kbookmarkmanager.cpp:335
> +        QString err = tr("Cannot launch keditbookmarks: %1\n\n"
> +                         "Most likely you do not have keditbookmarks currently installed").arg(keditbookmarks->errorString());
> +

Have you checked errorString actually returns something?

Given startDetached is static it seems kind of weird it would update the "this" errorString

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170619/247cfd06/attachment-0001.html>