D6233: KKeyServer: fix handling of KeypadModifier.

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> kkeyserver.cpp:976-980
> +        if (*keyQt != Qt::Key_Tab) { // KKeySequenceWidget does not map shift+tab to backtab
> +            static const int FirstLevelShift = 1;
> +            keySymX = xcb_key_symbols_get_keysym(symbols, e->detail, FirstLevelShift);
> +            KKeyServer::symXModXToKeyQt(keySymX, keyModX, keyQt);
> +        }

This is a special handling from KGlobalAccel. Are you sure it belongs into the generic implementation?

> kkeyserver_x11.h:161
> + */
> +KWINDOWSYSTEM_EXPORT bool symXModXToKeyQt(uint32_t keySym, uint16_t modX, int *keyQt);
>  

xkb has the modifier mask defined as uint32_t:

typedef uint32_t xkb_mod_mask_t

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D6233

To: dfaure, graesslin
Cc: graesslin, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170618/b2d44518/attachment.html>