D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

Dominik Haumann noreply at phabricator.kde.org
Sat Jun 17 15:45:18 UTC 2017


dhaumann added a comment.


  I am not yet convinced this is a good idea: We changed the foreground color of highlighted text just recently: https://git.reviewboard.kde.org/r/127554/diff/2/
  
  The idea is to have just one color for search results that need to match. This currently is the foreground color of normal text. We would need to really make sure all color schemes still work properly.
  
  As I understand, this is the case?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5802

To: intelfx, #kdevelop, #ktexteditor, #kate
Cc: dhaumann, mwolff, kwrite-devel, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170617/8d8a4ee9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list