Review Request 130146: Add angle brackets to matching brackets highlighting

[Dominik Haumann]

> On June 5, 2017, 12:53 p.m., Aleix Pol Gonzalez wrote:
> > I can see how this could be useful, but then it can be weird when '<' is used as less-than.

Indeed, this patch is problematic, since < and > is very often not balanced. As Aleix noted, this is the case for less than and greater than operations comparisons in programming languages, or the << and >> shift operators. The result in these cases would be more distracting than useful...

The proper fix would be add a KTextEditor interface with API to do this animation, then KDevelop or Kile could use this API and trigger these animations correctly.

That said, I'm not in favor of this patch, but thanks anyways!

If you have other ideas how to solve this problem, please shoot :-)


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130146/#review103284
-----------------------------------------------------------


On June 5, 2017, 12:42 p.m., Jakub Gargul wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130146/
> -----------------------------------------------------------
> 
> (Updated June 5, 2017, 12:42 p.m.)
> 
> 
> Review request for Kate and KDE Frameworks.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Highlighting matching angle brackets is useful, especially when multiple of them are nested (take c++ templates for example). The only quirk is that inequality signs most of the time aren't used as brackets and irrelevant portions of texts can be highlighted.
> 
> 
> Diffs
> -----
> 
>   src/document/katedocument.cpp 395a2cab 
> 
> Diff: https://git.reviewboard.kde.org/r/130146/diff/
> 
> 
> Testing
> -------
> 
> Compiled, turned animation and bracket range highlighting on and off, checked on file with lots of nested brackets.
> 
> 
> Thanks,
> 
> Jakub Gargul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170617/3ae6c116/attachment.html>