D6215: Make sure size is final after showEvent
David Edmundson
noreply at phabricator.kde.org
Fri Jun 16 13:31:44 UTC 2017
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Ok so in summary there's two changes here:
- updating our window geometry regardless of whether we're visible or not
Makes total sense, there's no bandwidth overhead the platform won't send anything if the window isn't mapped; but it means it has the right info for when we want it.
- not setting mainItem to invisible when the dialog is hidden.
We can see in gammaray all the contents now think they're visible. I'm quite wary of this as it was added for a reason.
The window doesn't render but we do have some code paths that release resources, and I'm pretty sure Animations (not Animators) will continue running.
---
But most crucially with this patch I don't get notifications (running unpatched p-w on XCB )
Can you test that combo please.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6215
To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170616/2a4e6dff/attachment.html>
More information about the Kde-frameworks-devel
mailing list