Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

[René J.V. Bertin]

> On April 1, 2017, 9:59 p.m., David Faure wrote:
> > Makes sense to me, +1.
> 
> Andreas Sturmlechner wrote:
>     Thanks, anyone else who wants to +1?
>     
>     I've tried to test migration today but it didn't work. May as well have nothing to do with te patch and be caused by the permanently troubled migration agent though... KMail happily gets its IMAP password from kwallet5 though after manually export/import via XML files.
> 
> Andreas Sturmlechner wrote:
>     As suspected, on my test system migration is broken regardless of with these patches or not.
> 
> David Faure wrote:
>     Are you planning on looking into that? ;-)
>     
>     These patches are related to migration, it feels a bit wrong to commit changes around migration and still leave it broken.
> 
> Andreas Sturmlechner wrote:
>     I don't feel like I'm up to that task. Also, the reason for why it works for some, but not all the systems, has afaik never been established.
> 
> Andreas Sturmlechner wrote:
>     Could we push it to give it some testing by others until the upcoming release?
> 
> René J.V. Bertin wrote:
>     Was this tested, in the end?
>     
>     I only became aware of the change after I installed 5.35.0 on my FrankenStux box with a Plasma4 desktop and KF5 installed into /opt/local, and I had to re-grant access to my wallets to all applications accessing them. 
>     
>     I cannot yet vouch that my wallets were migrated completely. I think they were, but how do I verify that now? Even the KDE4 kwalletmanager goes through kwalletd5. It too had to be granted access.
>     
>     Confusingly, it still shows the old access list, which clearly it shouldn't if the information is stale.
> 
> Andreas Sturmlechner wrote:
>     If you see your old wallets now in kwalletd5, then migration has worked. I've never heard about issues with partial migration; if it does not work, it fails to migrate completely.

That's the impression I had, but I never had to check. Migration was done about once after every time I logged in after a reboot. I never had to check though, kwalletd5 only served KF5 applications of which very few ever need wallet access in my case.

We'll see how this works out when I log in and /opt/local isn't available (which in theory is supposed to be possible).

To be seen also how this affects KDE/Mac users who have KDELibs4 configured to use my Keychain "backend". There's no kwalletd4 there, no migration either, and first impressions suggest the 2 systems continue to function in perfect isolation.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130058/#review102982
-----------------------------------------------------------


On May 27, 2017, 4:32 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130058/
> -----------------------------------------------------------
> 
> (Updated May 27, 2017, 4:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Stefan Brüns.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> These are not my own patches, I'm creating this review request after having been made aware of *kwalletd4_dbus_compat* branch in kwallet.git, which I simply rebased on top of current master (author of course preserved) to be able to test it. I think it would be a great improvement over the current situation that is rather confusing to the users.
> 
> The changes are organised in 5 commits:
> 
> - Check for unique applicaton instance as early as possible
> Exit before KWalletD and the MigrationAgent has been initialized.
> The return value is changed, but concurrent instatiation of kwalletd is
> not a fault.
> 
> - Only start timer for migration agent if necessary
> - Whitespace fixup
> - Signal completion of migration agent
> - Replace kwalletd4 after migration has finished
> kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/kwalletd.h 3571535cd8bd78415002795f9b61adf9f6cfb8c1 
>   src/runtime/kwalletd/kwalletd.cpp 18ef9fa7e6ddaeba6e0b32deae3de1dae39df5bb 
>   src/runtime/kwalletd/main.cpp ff9620886fa1959e14b594be6bbb4644b637c000 
>   src/runtime/kwalletd/migrationagent.h 0f6467c1753ef34b7f7f7e282503ec5607927db9 
>   src/runtime/kwalletd/migrationagent.cpp f3da94743ecd83fe406e058f560d4238caec1be8 
> 
> Diff: https://git.reviewboard.kde.org/r/130058/diff/
> 
> 
> Testing
> -------
> 
> Migration itself was not tested so far, but a legacy application like ksirk was able to create a new wallet just fine and can access it as well. I do not have kwalletd4 installed anymore.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170615/153d21bc/attachment.html>