D6215: Introduce aboutToShow() signal

Marco Martin noreply at phabricator.kde.org
Tue Jun 13 16:11:28 UTC 2017


mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  introduce this new signal: make sure the size of the dialog
  is final, sinced with the main item and the optional layout
  after the abouttoshow signal and right before actually showing
  it: clients with custom positioning can safely position the dialog
  in its signal handler as they know it won't resize when shown.
  
  this makes synctomaintem and updatelayoutparameters working even if
  the dialog is not visible as we need to resize beforehand
  
  first user of this will be the notifications applet

TEST PLAN
  current dialog users behave the same, tests still pass
  notifications applet reworked to use this works as expected

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6215

AFFECTED FILES
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialog.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170613/2ee2388e/attachment.html>


More information about the Kde-frameworks-devel mailing list