D6190: Expose and use Engine's page size variable

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Jun 12 13:12:17 UTC 2017


apol added a comment.


  I have no idea about the patch itself, why it wasn't exposed so far that is.

INLINE COMMENTS

> engine.cpp:144
> +     */
> +    void setPageSize(const int& pageSize);
>  Q_SIGNALS:

I wouldn't pass an int as `const&`

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6190

To: leinir, #knewstuff
Cc: apol, #frameworks, ZrenBot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170612/6cc3069f/attachment.html>


More information about the Kde-frameworks-devel mailing list